liurenjie1024 merged PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Xuanwo commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1693030831
##
crates/iceberg/src/io/storage.rs:
##
Review Comment:
Follow-up issues tracked at https://github.com/apache/iceberg-rust/issues/484
--
This is an automated
Xuanwo commented on PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#issuecomment-2252713484
Should merge after https://github.com/apache/iceberg-rust/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Xuanwo commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1693014389
##
crates/iceberg/src/io/storage.rs:
##
Review Comment:
> * Could we add some tests to verify it? I think it should be easy since we
have it as default feature.
Xuanwo commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1693014389
##
crates/iceberg/src/io/storage.rs:
##
Review Comment:
> * Could we add some tests to verify it? I think it should be easy since we
have it as default feature.
liurenjie1024 commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1692979724
##
crates/iceberg/src/io/storage.rs:
##
Review Comment:
1. Could we add some tests to verify it? I think it should be easy since we
have it as default fe
fqaiser94 commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691486557
##
crates/iceberg/src/io/storage.rs:
##
@@ -79,6 +87,16 @@ impl Storage {
) -> crate::Result<(Operator, &'a str)> {
let path = path.as_ref();
Xuanwo commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691497746
##
crates/iceberg/src/io/storage.rs:
##
@@ -79,6 +87,16 @@ impl Storage {
) -> crate::Result<(Operator, &'a str)> {
let path = path.as_ref();
m
fqaiser94 commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691489187
##
crates/iceberg/src/io/storage_memory.rs:
##
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
