Xuanwo commented on code in PR #481: URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1693014389
########## crates/iceberg/src/io/storage.rs: ########## Review Comment: > * Could we add some tests to verify it? I think it should be easy since we have it as default feature. Current test is not extsiable for different storage service, please allow me to complement them in a new PR. For example, I can refactor `test_local_input_file`, `test_delete_local_file`, ... to make them work on different file io instead. > Could we have a simple doc to explain how to use it? At least for me, it's not straight forward without refering to opendal's doc. Sure, I will add this, ########## crates/iceberg/src/io/storage.rs: ########## Review Comment: > * Could we add some tests to verify it? I think it should be easy since we have it as default feature. Current test is not extsiable for different storage service, please allow me to complement them in a new PR. For example, I can refactor `test_local_input_file`, `test_delete_local_file`, ... to make them work on different file io instead. > Could we have a simple doc to explain how to use it? At least for me, it's not straight forward without refering to opendal's doc. Sure, I will add this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
