syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-2085259321
@Fokko @HonahX @jaychia - should we remove this from the 0.7.0 milestone? I
think we'd benefit from a prolonged discussion and attempt in organizing our
API. This feels like an item w
syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-2020988016
@jaychia 'suggestion -> reorganize modules to the top level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1971358205
> Hey @syun64 Thanks for adding the yaml, that looks neat. What's your gist
of Griffe? It looks like there are already some false positives.
Thank you for all the feedback @Fokk
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506659256
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506659256
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506659256
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506201735
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506201735
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506201735
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
syun64 commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506160666
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1968885563
Hey @syun64 Thanks for adding the yaml, that looks neat. What's your gist of
Griffe? It looks like there are already some false positives.
--
This is an automated message from the Ap
Fokko commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1505878347
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
Fokko commented on code in PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1505877915
##
tests/api/exclude/pyiceberg-0.6.0.yaml:
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1959670410
> Looks like we broke something already 😸 Can we make a list to allow
breaking changes? Similar to
https://github.com/apache/parquet-mr/blob/d8396086b3e3fefc6829f8640917c3bbde0fa9c4/p
Fokko commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1959164253
Looks like we broke something already 😸 Can we make a list to allow breaking
changes? Similar to
https://github.com/apache/parquet-mr/blob/d8396086b3e3fefc6829f8640917c3bbde0fa9c4/pom.
Fokko commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1955199604
@syun64 I was on a merging spree, can you rebase once more? 😓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Fokko commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1944095694
Thanks for setting this up @syun64. This looks great. I think we can just
give it a try after the 0.6.0 release and see how noisy it is.
--
This is an automated message from the Apac
syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1942088750
| Breakage Kind | Description
| Ignore | Rationale
syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1938785088
Which of these [breaking change
types](https://github.com/mkdocstrings/griffe/blob/2359a02aef3cdc1776608a9e507c0096285e1d75/src/griffe/enumerations.py#L86)
we should include in our un
syun64 commented on PR #394:
URL: https://github.com/apache/iceberg-python/pull/394#issuecomment-1934357519
An issue I'm currently investigating is that 58 breaking changes are being
reported between 0.5.1 and 0e273ae when the test is run in my local environment.
When test_api.py was
20 matches
Mail list logo
