syun64 commented on code in PR #394: URL: https://github.com/apache/iceberg-python/pull/394#discussion_r1506201735
########## tests/api/exclude/pyiceberg-0.6.0.yaml: ########## @@ -0,0 +1,47 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# The format of this file is documented at +# https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features + +exclude: +- obj_path: pyiceberg.avro.decoder_fast.CythonBinaryDecoder + kind: CLASS_REMOVED_BASE +- obj_path: pyiceberg.table.create_mapping_from_schema + kind: OBJECT_REMOVED +- obj_path: pyiceberg.avro.decoder_fast.BinaryDecoder + kind: OBJECT_REMOVED +- obj_path: pyiceberg.avro.decoder_fast.CythonBinaryDecoder.tell Review Comment: This is getting pretty interesting! As you mentioned, from the diff it looks like CythonBinaryDecoder wasn't updated, but when I run help() on pyiceberg.avro.decoder_fast.CythonBinaryDecoder, I'm loading: ``` class CythonBinaryDecoder(builtins.object) | Implement a BinaryDecoder that reads from an in-memory buffer. | | Methods defined here: | | __reduce__ = __reduce_cython__(...) | | __setstate__ = __setstate_cython__(...) | | read(self, n: 'int') | Read n bytes. | | read_boolean(self) -> 'bool' | Reads a value from the stream as a boolean. | | A boolean is written as a single byte | whose value is either 0 (false) or 1 (true). | | read_bytes(self) | Bytes are encoded as a long followed by that many bytes of data. | | read_double(self) | Reads a value from the stream as a double. | | A double is written as 8 bytes. | The double is converted into a 64-bit integer using a method equivalent to | Java's doubleToLongBits and then encoded in little-endian format. | | read_float(self) | Reads a value from the stream as a float. | | A float is written as 4 bytes. | The float is converted into a 32-bit integer using a method equivalent to | Java's floatToIntBits and then encoded in little-endian format. ``` Which explains why methods like `read_double`, `read_float` are being reported to having their types changed, whereas `read_boolean` is being reported to having maintained the same interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
