Re: [PR] chore: more consistently use type conversions [iceberg-rust]

2024-12-17 Thread via GitHub
roeap commented on PR #815: URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550581317 @Xuanwo @liurenjie1024 - understood. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] chore: more consistently use type conversions [iceberg-rust]

2024-12-17 Thread via GitHub
roeap closed pull request #815: chore: more consistently use type conversions URL: https://github.com/apache/iceberg-rust/pull/815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] chore: more consistently use type conversions [iceberg-rust]

2024-12-17 Thread via GitHub
liurenjie1024 commented on PR #815: URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550191862 Thanks @roeap for contributing! About this pr, I agree with @Xuanwo that explicit function call makes code easier to read, and there is no strong motivation to change it to `TryF

Re: [PR] chore: more consistently use type conversions [iceberg-rust]

2024-12-17 Thread via GitHub
Xuanwo commented on PR #815: URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550171155 Hi, thank you @roeap for working on this. It's intentional that we provide a clear API for the conversion. This ensures an easy-to-find and discoverable API for users. In the near futur