liurenjie1024 commented on PR #815: URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550191862
Thanks @roeap for contributing! About this pr, I agree with @Xuanwo that explicit function call makes code easier to read, and there is no strong motivation to change it to `TryFrom`. But I agree that maybe we could provide a `TryFrom` implementation so that external users could choose it freely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
