Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-22 Thread via GitHub
kevinjqliu merged PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-22 Thread via GitHub
kevinjqliu closed pull request #1360: check mkdocs build strict in CI URL: https://github.com/apache/iceberg-python/pull/1360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-22 Thread via GitHub
Fokko commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1853583770 ## .github/workflows/python-ci.yml: ## @@ -49,5 +49,7 @@ jobs: run: make install-dependencies - name: Linters run: make lint +- name: Check

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-21 Thread via GitHub
kevinjqliu commented on PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#issuecomment-2492615027 verified that CI breaks with bad doc changes https://github.com/apache/iceberg-python/actions/runs/11963956201/job/33355402732?pr=1360 -- This is an automated message from the

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-21 Thread via GitHub
kevinjqliu commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1853108710 ## .github/workflows/python-ci.yml: ## @@ -49,5 +49,7 @@ jobs: run: make install-dependencies - name: Linters run: make lint +- name: C

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-21 Thread via GitHub
kevinjqliu commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1853107082 ## .github/workflows/python-ci.yml: ## @@ -49,5 +49,7 @@ jobs: run: make install-dependencies - name: Linters run: make lint +- name: C

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-21 Thread via GitHub
kevinjqliu commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1853106916 ## pyproject.toml: ## @@ -95,6 +95,17 @@ pyspark = "3.5.3" cython = "3.0.11" deptry = ">=0.14,<0.22" docutils = "!=0.21.post1" # https://github.com/pyth

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-21 Thread via GitHub
kevinjqliu commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1853105652 ## .github/workflows/python-ci-docs.yml: ## Review Comment: this will now run on every PR when there's a change in `mkdocs/docs/` ## .github/w

Re: [PR] check mkdocs build strict in CI [iceberg-python]

2024-11-21 Thread via GitHub
Fokko commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1852923680 ## pyproject.toml: ## @@ -95,6 +95,17 @@ pyspark = "3.5.3" cython = "3.0.11" deptry = ">=0.14,<0.22" docutils = "!=0.21.post1" # https://github.com/python-po