Fokko commented on code in PR #1360: URL: https://github.com/apache/iceberg-python/pull/1360#discussion_r1852923680
########## pyproject.toml: ########## @@ -95,6 +95,17 @@ pyspark = "3.5.3" cython = "3.0.11" deptry = ">=0.14,<0.22" docutils = "!=0.21.post1" # https://github.com/python-poetry/poetry/issues/9248#issuecomment-2026240520 +mkdocs = "1.6.1" Review Comment: By adding this to poetry as well, we need to keep this in sync with the `requirements.txt`: https://github.com/apache/iceberg-python/blob/main/mkdocs/requirements.txt ########## .github/workflows/python-ci.yml: ########## @@ -49,5 +49,7 @@ jobs: run: make install-dependencies - name: Linters run: make lint + - name: Check MkDocs Review Comment: Do we need to download and install mkdocs and test it for each of the Python versions? What do you think of creating a new workflow similar to the publish-docs one? https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci-docs.yml. This one could then only trigger on changes under `docs/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
