Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-10-08 Thread via GitHub
huaxingao commented on PR #10622: URL: https://github.com/apache/iceberg/pull/10622#issuecomment-2400850614 cc @aihuaxu @RussellSpitzer Spark 4.0 preview1 works OK now with the new [PR](https://github.com/apache/iceberg/pull/11257), but there are still a few issues with Preview 2. I am

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-10-08 Thread via GitHub
huaxingao closed pull request #10622: WIP: Initial Support for Spark 4.0 URL: https://github.com/apache/iceberg/pull/10622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-10-08 Thread via GitHub
huaxingao commented on PR #10622: URL: https://github.com/apache/iceberg/pull/10622#issuecomment-2400841583 It's easier to have a new PR than update this one. I am closing this one and open a new [PR](https://github.com/apache/iceberg/pull/11257) -- This is an automated message from the A

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-09-26 Thread via GitHub
RussellSpitzer commented on code in PR #10622: URL: https://github.com/apache/iceberg/pull/10622#discussion_r1777341211 ## spark/v3.5/spark/src/jmh/java/org/apache/iceberg/spark/action/RandomGeneratingUDF.java: ## @@ -29,7 +29,7 @@ class RandomGeneratingUDF implements Seriali

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-09-26 Thread via GitHub
RussellSpitzer commented on code in PR #10622: URL: https://github.com/apache/iceberg/pull/10622#discussion_r1777338194 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java: ## @@ -255,7 +255,7 @@ protected void c

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-09-26 Thread via GitHub
RussellSpitzer commented on code in PR #10622: URL: https://github.com/apache/iceberg/pull/10622#discussion_r1777339828 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -948,9 +948,9 @@ public void testAddFilesWit

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-09-26 Thread via GitHub
RussellSpitzer commented on code in PR #10622: URL: https://github.com/apache/iceberg/pull/10622#discussion_r1777326975 ## .github/workflows/java-ci.yml: ## @@ -107,7 +107,7 @@ jobs: runs-on: ubuntu-22.04 strategy: matrix: -jvm: [8, 11, 17] +jvm:

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-07-17 Thread via GitHub
raphaelauv commented on PR #10622: URL: https://github.com/apache/iceberg/pull/10622#issuecomment-2233219459 btw spark 4 is going to use parquet 1.14.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] WIP: Initial Support for Spark 4.0 [iceberg]

2024-07-03 Thread via GitHub
amogh-jahagirdar commented on PR #10622: URL: https://github.com/apache/iceberg/pull/10622#issuecomment-2206939528 Updated the description to link #10497, this is great to see @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on