RussellSpitzer commented on code in PR #10622:
URL: https://github.com/apache/iceberg/pull/10622#discussion_r1777339828
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -948,9 +948,9 @@ public void testAddFilesWithParallelism() {
sql("SELECT * FROM %s ORDER BY id", tableName));
}
- private static final List<Object[]> EMPTY_QUERY_RESULT =
Lists.newArrayList();
+ private static final List<Object[]> emptyQueryResult = Lists.newArrayList();
Review Comment:
Not sure why we are changing the constant here
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -948,9 +948,9 @@ public void testAddFilesWithParallelism() {
sql("SELECT * FROM %s ORDER BY id", tableName));
}
- private static final List<Object[]> EMPTY_QUERY_RESULT =
Lists.newArrayList();
+ private static final List<Object[]> emptyQueryResult = Lists.newArrayList();
- private static final StructField[] STRUCT = {
+ private static final StructField[] struct = {
Review Comment:
or here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
