Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-20 Thread via GitHub
HonahX merged PR #626: URL: https://github.com/apache/iceberg-python/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-19 Thread via GitHub
kevinjqliu commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1572919996 ## Makefile: ## @@ -63,6 +63,7 @@ test-coverage: docker compose -f dev/docker-compose-integration.yml up -d sh ./dev/run-azurite.sh sh .

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-19 Thread via GitHub
kevinjqliu commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1572917220 ## Makefile: ## @@ -63,6 +63,7 @@ test-coverage: docker compose -f dev/docker-compose-integration.yml up -d sh ./dev/run-azurite.sh sh .

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-19 Thread via GitHub
kevinjqliu commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1572915541 ## mkdocs/docs/verify-release.md: ## @@ -105,15 +105,17 @@ make test To run the full integration tests: ```sh -make test-s3 +make test-integration Review C

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-18 Thread via GitHub
HonahX commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1571811203 ## mkdocs/docs/verify-release.md: ## @@ -105,15 +105,17 @@ make test To run the full integration tests: ```sh -make test-s3 +make test-integration Review Comme

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-18 Thread via GitHub
kevinjqliu commented on PR #626: URL: https://github.com/apache/iceberg-python/pull/626#issuecomment-2065491774 @Fokko @HonahX does it make sense to add the "verify release" link to the release email template? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-18 Thread via GitHub
kevinjqliu commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1571514702 ## mkdocs/docs/verify-release.md: ## @@ -105,15 +105,17 @@ make test To run the full integration tests: ```sh -make test-s3 +make test-integration Review C

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-18 Thread via GitHub
geruh commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1571468239 ## mkdocs/docs/verify-release.md: ## @@ -105,15 +105,17 @@ make test To run the full integration tests: ```sh -make test-s3 +make test-integration ``` -This w

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-18 Thread via GitHub
geruh commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1571466306 ## mkdocs/docs/verify-release.md: ## @@ -105,15 +105,17 @@ make test To run the full integration tests: ```sh -make test-s3 +make test-integration Review Commen

Re: [PR] Verify release quality of life improvements [iceberg-python]

2024-04-18 Thread via GitHub
kevinjqliu commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1571442239 ## mkdocs/docs/verify-release.md: ## @@ -105,15 +105,17 @@ make test To run the full integration tests: Review Comment: I did not fully understand L87-89.