HonahX commented on code in PR #626: URL: https://github.com/apache/iceberg-python/pull/626#discussion_r1571811203
########## mkdocs/docs/verify-release.md: ########## @@ -105,15 +105,17 @@ make test To run the full integration tests: ```sh -make test-s3 +make test-integration Review Comment: I think here we can use ``` make test-coverage ``` This option will run all unit tests, integration tests, and tests for s3fs, adlfs, gcsfs. It can also generate a test coverage report This is also the command used by the CI: https://github.com/apache/iceberg-python/blob/e74ec4a89715f93852dfce4bb29f19463b1d54ef/.github/workflows/python-ci.yml#L53 ########## mkdocs/docs/how-to-release.md: ########## @@ -143,6 +143,10 @@ https://pypi.org/project/pyiceberg/$VERSION/ And can be installed using: pip3 install pyiceberg==$VERSION +Instructions for verifying a release can be found here: + +* https://py.iceberg.apache.org/verify-release/ Review Comment: I think adding this can help a lot! Especially for those verifying a release for the first time 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
