jqin61 commented on PR #582:
URL: https://github.com/apache/iceberg-python/pull/582#issuecomment-2045791559
A delete + append will do the static overwrite and most of the validation
will be done by delete itself. Closing the pr and will open a static overwrite
PR when DELETE and MERGE_APPEN
jqin61 closed pull request #582: Validate overwrite filter
URL: https://github.com/apache/iceberg-python/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
Fokko commented on PR #582:
URL: https://github.com/apache/iceberg-python/pull/582#issuecomment-2043480905
> If we wanted to handle the validation only in the delete function by
checking if we would end up rewriting files, above pattern would succeed by
deleting level = 'INFO' and dt = '202
syun64 commented on PR #582:
URL: https://github.com/apache/iceberg-python/pull/582#issuecomment-2043441654
Hi @Fokko @adrianqin I think the goal of this PR is to create a distinction
to the semantic of a 'static overwrite' onto a partitioned table, from that of
a 'delete' + 'append'.
Fokko commented on code in PR #582:
URL: https://github.com/apache/iceberg-python/pull/582#discussion_r1555374364
##
pyiceberg/io/pyarrow.py:
##
@@ -1776,7 +1776,10 @@ def write_parquet(task: WriteTask) -> DataFile:
fo = io.new_output(file_path)
with fo.create(
Fokko commented on PR #582:
URL: https://github.com/apache/iceberg-python/pull/582#issuecomment-2042152141
Hi Adrian, thanks for working on this and the very comprehensive write-up.
My first questions is, what is the main goal of this PR.
Let me elaborate with more context. Looking at
