Fokko commented on code in PR #582:
URL: https://github.com/apache/iceberg-python/pull/582#discussion_r1555374364
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1776,7 +1776,10 @@ def write_parquet(task: WriteTask) -> DataFile:
fo = io.new_output(file_path)
with fo.create(overwrite=True) as fos:
with pq.ParquetWriter(fos, schema=arrow_file_schema,
**parquet_writer_kwargs) as writer:
- writer.write(pa.Table.from_batches(task.record_batches),
row_group_size=row_group_size)
+ arrow_table = pa.Table.from_batches(task.record_batches)
+ # align the columns accordingly in case input arrow table has
columns in order different from iceberg table
Review Comment:
Can you provide an example of when this would happen? This only handles
top-level columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
