Re: [PR] Update checkstyle definition [iceberg]

2024-07-24 Thread via GitHub
RussellSpitzer commented on PR #10681: URL: https://github.com/apache/iceberg/pull/10681#issuecomment-2248879112 Thanks @attilakreiner for the commit and @findepi for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Update checkstyle definition [iceberg]

2024-07-24 Thread via GitHub
RussellSpitzer merged PR #10681: URL: https://github.com/apache/iceberg/pull/10681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Update checkstyle definition [iceberg]

2024-07-15 Thread via GitHub
RussellSpitzer commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1678370083 ## .baseline/checkstyle/checkstyle.xml: ## @@ -281,16 +280,13 @@ - - + Review Comment:

Re: [PR] Update checkstyle definition [iceberg]

2024-07-15 Thread via GitHub
attilakreiner commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1678355098 ## .baseline/checkstyle/checkstyle.xml: ## @@ -281,16 +280,13 @@ - - + Review Comment: T

Re: [PR] Update checkstyle definition [iceberg]

2024-07-15 Thread via GitHub
attilakreiner commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1678355098 ## .baseline/checkstyle/checkstyle.xml: ## @@ -281,16 +280,13 @@ - - + Review Comment: T

Re: [PR] Update checkstyle definition [iceberg]

2024-07-15 Thread via GitHub
attilakreiner commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1678355098 ## .baseline/checkstyle/checkstyle.xml: ## @@ -281,16 +280,13 @@ - - + Review Comment: T

Re: [PR] Update checkstyle definition [iceberg]

2024-07-15 Thread via GitHub
RussellSpitzer commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1678312407 ## .baseline/checkstyle/checkstyle.xml: ## @@ -281,16 +280,13 @@ - - + Review Comment:

Re: [PR] Update checkstyle definition [iceberg]

2024-07-11 Thread via GitHub
attilakreiner commented on PR #10681: URL: https://github.com/apache/iceberg/pull/10681#issuecomment-2223052922 Merged in the `main` branch and fixed `ConstantName`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Update checkstyle definition [iceberg]

2024-07-11 Thread via GitHub
findepi commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1673988656 ## .baseline/checkstyle/checkstyle.xml: ## @@ -480,23 +475,20 @@ - + -

Re: [PR] Update checkstyle definition [iceberg]

2024-07-11 Thread via GitHub
attilakreiner commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1673979787 ## .baseline/checkstyle/checkstyle.xml: ## @@ -480,23 +475,20 @@ - + -

Re: [PR] Update checkstyle definition [iceberg]

2024-07-11 Thread via GitHub
attilakreiner commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1673979787 ## .baseline/checkstyle/checkstyle.xml: ## @@ -480,23 +475,20 @@ - + -

Re: [PR] Update checkstyle definition [iceberg]

2024-07-11 Thread via GitHub
findepi commented on code in PR #10681: URL: https://github.com/apache/iceberg/pull/10681#discussion_r1673961429 ## .baseline/checkstyle/checkstyle.xml: ## @@ -480,23 +475,20 @@ - + -