findepi commented on code in PR #10681:
URL: https://github.com/apache/iceberg/pull/10681#discussion_r1673961429
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -480,23 +475,20 @@
<module name="LocalFinalVariableName"/> <!-- Java Style Guide: Local
variable names -->
<module name="LocalVariableName"> <!-- Java Style Guide: Local
variable names -->
<property name="tokens" value="VARIABLE_DEF"/>
- <property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
+ <property name="format" value="^[a-z][a-zA-Z0-9]++$"/>
<property name="allowOneCharVarInForLoop" value="true"/>
- <message key="name.invalidPattern" value="Local variable name
''{0}'' must match pattern ''{1}''."/>
</module>
<module name="MethodLength"/> <!-- Java Coding Guide: Methods and
functions: focused, crisp, concise -->
<module name="MethodTypeParameterName"> <!-- Java Style Guide: Type
variable names -->
- <property name="format"
value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
- <message key="name.invalidPattern" value="Method type name ''{0}''
must match pattern ''{1}''."/>
+ <property name="format"
value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*+[T]$)"/>
Review Comment:
This one imo can't be possessive because of the trailing `T` requirement.
For example `FooT` matched the previous pattern, but does not match the new
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
