Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2578300672 > Going to merge this PR as is and we can deal with nit comment as a followup I've put up #1499 for the nits. -- This is an automated message from the Apache Git Se

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1907587480 ## tests/integration/test_partitioning_key.py: ## @@ -721,6 +753,27 @@ VALUES (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP),

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1907551758 ## tests/integration/test_partitioning_key.py: ## @@ -721,6 +753,27 @@ VALUES (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAS

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1907541402 ## tests/integration/test_partitioning_key.py: ## @@ -721,6 +753,27 @@ VALUES (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP),

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2578213037 Sounds good, thanks Kevin for your excellent review here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu merged PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1901220393 ## tests/integration/test_partitioning_key.py: ## @@ -721,6 +753,27 @@ VALUES (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAS

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

Fokko commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1899068027 ## pyiceberg/partitioning.py: ## @@ -234,9 +234,11 @@ def partition_to_path(self, data: Record, schema: Schema) -> str: partition_field = self.fields

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

Fokko commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1899067852 ## pyiceberg/partitioning.py: ## @@ -234,9 +234,11 @@ def partition_to_path(self, data: Record, schema: Schema) -> str: partition_field = self.fields

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2560428546 Thanks a lot for this explanation and suggestion @kevinjqliu! It sounds good. Had some time so I've made this change so tests pass - using `make_compatible_name` as a

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2560171094 Thanks for the PR! I've dug into the test failure a bit. Heres what I found. There's a subtle difference between `PartitionKey.partition` and `DataFile.partition`. In mos

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2559759825 Done, @kevinjqliu. Fails due to https://github.com/apache/iceberg-python/pull/1457#discussion_r1894689633 but will think over it. FYI, am away for a little bit now s

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1895780803 ## tests/table/test_partitioning.py: ## @@ -118,6 +119,27 @@ def test_deserialize_partition_spec() -> None: ) +def test_partition_spec_to_path()

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1895779686 ## tests/table/test_partitioning.py: ## @@ -118,6 +119,27 @@ def test_deserialize_partition_spec() -> None: ) +def test_partition_spec_to_path()

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1895780803 ## tests/table/test_partitioning.py: ## @@ -118,6 +119,27 @@ def test_deserialize_partition_spec() -> None: ) +def test_partition_spec_to_path()

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1895779686 ## tests/table/test_partitioning.py: ## @@ -118,6 +119,27 @@ def test_deserialize_partition_spec() -> None: ) +def test_partition_spec_to_path()

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1895779686 ## tests/table/test_partitioning.py: ## @@ -118,6 +119,27 @@ def test_deserialize_partition_spec() -> None: ) +def test_partition_spec_to_path()

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2558846223 Done, @kevinjqliu. FYI, am away for a bit now so will pick this back up in the new year! (Feel free to take over this if it's urgently required 😄) -- This is an automated

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2558596455 BTW #1462 is merged, could you rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894687973 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01'

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894689633 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01'

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894689301 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01' AS DA

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894687973 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01'

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894684638 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01' AS DA

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894684487 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01' AS DA

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894677718 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01'

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894677409 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01'

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

kevinjqliu commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894666959 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01' AS DA

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894517823 ## tests/integration/test_partitioning_key.py: ## @@ -722,6 +723,25 @@ (CAST('2023-01-01 11:55:59.99' AS TIMESTAMP), CAST('2023-01-01'

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894501982 ## tests/integration/test_partitioning_key.py: ## @@ -203,10 +203,11 @@ # """ ), ( -[PartitionField(source_id=

Re: [PR] URL-encode partition field names in file locations [iceberg-python]

smaheshwar-pltr commented on code in PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894501982 ## tests/integration/test_partitioning_key.py: ## @@ -203,10 +203,11 @@ # """ ), ( -[PartitionField(source_id=