smaheshwar-pltr commented on code in PR #1457:
URL: https://github.com/apache/iceberg-python/pull/1457#discussion_r1894677409
##########
tests/integration/test_partitioning_key.py:
##########
@@ -722,6 +723,25 @@
(CAST('2023-01-01 11:55:59.999999' AS TIMESTAMP),
CAST('2023-01-01' AS DATE), 'some data');
""",
),
+ # Test that special characters are URL-encoded
+ (
+ [PartitionField(source_id=15, field_id=1001,
transform=IdentityTransform(), name="special#string#field")],
+ ["special string"],
+ Record(**{"special#string#field": "special string"}), # type:
ignore
+ "special%23string%23field=special%20string",
+ f"""CREATE TABLE {identifier} (
+ `special#string#field` string
+ )
+ USING iceberg
+ PARTITIONED BY (
+ identity(`special#string#field`)
+ )
+ """,
+ f"""INSERT INTO {identifier}
+ VALUES
+ ('special string')
+ """,
+ ),
Review Comment:
Thanks @kevinjqliu. And the first failure is because the Iceberg version on
`spark` was before https://github.com/apache/iceberg/pull/10329, so it's not
URL-encoded (I think).
Given this, I've disabled justification with a message similar to other
tests here where behaviour differs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
