Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-31 Thread via GitHub
sungwy merged PR #973: URL: https://github.com/apache/iceberg-python/pull/973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-31 Thread via GitHub
ndrluis commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2260972102 Just to clarify the test changes: ``` "ignore:A plugin raised an exception during an old-style hookwrapper teardown.", "ignore:unclosed

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-30 Thread via GitHub
Fokko commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2259753059 @ndrluis Ohh, this is nice. And sorry, it looks like I disabled this out a while ago https://github.com/apache/iceberg-python/commit/0cbb71cb86c1952d40508681ea1ff96f009d5d79 🙈 --

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-30 Thread via GitHub
sungwy commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2259529801 Thank you! Running the CI now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-30 Thread via GitHub
ndrluis commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2259525851 @sungwy Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-30 Thread via GitHub
sungwy commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2259391639 @ndrluis shall we rebase this branch with the fix you issued in the other PR #972 ? ``` ERROR tests/integration/test_writes/test_writes.py::test_rest_catalog_with_empty_cata

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-28 Thread via GitHub
ndrluis commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2254637205 Thank you for the review, @sungwy. I made the change in commit [1c6c409](https://github.com/apache/iceberg-python/pull/973/commits/1c6c40903edc448ca67daa2460a5e84a2abe1639). -- Thi

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-27 Thread via GitHub
sungwy commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2254297106 Hi @ndrluis - thank you for turning the issue in https://github.com/apache/iceberg-python/issues/971 into these strategic items so quickly. I'm +1 for re-enabling this flag as