sungwy commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2254297106
Hi @ndrluis - thank you for turning the issue in https://github.com/apache/iceberg-python/issues/971 into these strategic items so quickly. I'm +1 for re-enabling this flag as it will help us avoid issues like you've reported. Testing this out in my dev environment, I see that other tests would also end up breaking with "expected" UserWarnings. And example is: `UserWarning: Delete operation did not match any records`, when `overwrite` is invoked in an empty table. Some of our tests like: [tests/catalog/test_sql.py::test_write_pyarrow_schema](https://github.com/HonahX/iceberg-python/blob/9b6503def4f07a70149da07378f4795c3a4b113b/tests/catalog/test_sql.py#L343) would fail in this case. One suggestion is to update this test to use `table.append(pyarrow_table)` instead so that these expected user warnings will not break our CI. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
