Fokko closed pull request #433: Support for REPLACE TABLE operation
URL: https://github.com/apache/iceberg-python/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Fokko commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-2927771179
Closing this as suggested by @anupam-saini. Looking forward seeing this
being added to PyIceberg 🚀
--
This is an automated message from the Apache Git Service.
To respond to the mes
srilman commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-2715949876
@anupam-saini Yep was planning to. Feel free to close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
smaheshwar-pltr commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-2710268654
> Are you still working on this PR? For context, we are doing some
interesting (and probably wrong) stuff to mimic Iceberg Java's REPLACE TABLE in
https://github.com/bodo-ai/
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-2709180688
> @anupam-saini Are you still working on this PR? For context, we are doing
some _interesting_ (and probably wrong) stuff to mimic Iceberg Java's REPLACE
TABLE in
https://githu
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-2709181733
@srilman let me know if you would like to open a new PR. I can close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
srilman commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-2708554806
@anupam-saini Are you still working on this PR? For context, we are doing
some _interesting_ (and probably wrong) stuff to mimic Iceberg Java's REPLACE
TABLE in
https://github.com/b
Fokko commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1579083787
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_properties
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1527602013
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_prop
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1527602013
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_prop
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1527602013
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_prop
Fokko commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1524545642
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_properties
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1972462085
Now with Sort Order and Partition Spec updates, this PR has all the
necessary pieces for create-replace table operation and is ready for review.
@Fokko @syun64
--
This
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1496863736
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return visit(schema_
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1493065425
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return visit(schema_
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1949447704
Thank you @Fokko for taking time to explain in such great detail. Now it
makes much more sense to have this part of the Catalog API. Made changes as
suggested.
--
This is an
syun64 commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1493052840
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return visit(schema_or_typ
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1493051291
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return visit(schema_
Fokko commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1948180604
@anupam-saini Thanks for working on this. I'm not sure if the following API
is where people would expect it:
```python
with table.transaction() as transaction:
transact
syun64 commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1491658399
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return visit(schema_or_typ
20 matches
Mail list logo
