Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-10-09 Thread via GitHub
rdblue merged PR #10955: URL: https://github.com/apache/iceberg/pull/10955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-10-09 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1794205253 ## format/spec.md: ## @@ -1089,6 +1118,7 @@ The types below are not currently valid for bucketing, and so are not hashed. Ho | Primitive type | Hash specificat

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-10-09 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1794202328 ## format/spec.md: ## @@ -1089,6 +1118,7 @@ The types below are not currently valid for bucketing, and so are not hashed. Ho | Primitive type | Hash specificat

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-10-08 Thread via GitHub
emkornfield commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1792890848 ## format/spec.md: ## @@ -230,11 +233,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-10-08 Thread via GitHub
emkornfield commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1792888066 ## format/spec.md: ## @@ -1089,6 +1118,7 @@ The types below are not currently valid for bucketing, and so are not hashed. Ho | Primitive type | Hash speci

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
emkornfield commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779268706 ## format/spec.md: ## @@ -230,11 +233,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
emkornfield commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779268258 ## format/spec.md: ## @@ -174,6 +174,7 @@ Supported primitive types are defined in the table below. Primitive types added | Added by version | Primitive type

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
emkornfield commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779248853 ## format/spec.md: ## @@ -230,11 +233,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779174675 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the table

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r177917 ## format/spec.md: ## @@ -174,6 +174,7 @@ Supported primitive types are defined in the table below. Primitive types added | Added by version | Primitive type |

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
rdblue commented on PR #10955: URL: https://github.com/apache/iceberg/pull/10955#issuecomment-2380082777 @aihuaxu, @RussellSpitzer, I've removed variant from this PR so that we can make progress on the type promotion. Now this just includes `unknown` and the new promotions. We can make prog

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779173577 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the table

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779173577 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the table

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-27 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1779172676 ## format/spec.md: ## @@ -950,6 +977,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`uuid`**|`{ "type": "fixed",`  `"size":

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767620992 ## format/spec.md: ## @@ -1267,6 +1304,7 @@ This serialization scheme is for storing single values as individual binary valu | **`fixed(L)`** |

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767620992 ## format/spec.md: ## @@ -1267,6 +1304,7 @@ This serialization scheme is for storing single values as individual binary valu | **`fixed(L)`** |

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767618482 ## format/spec.md: ## @@ -1003,6 +1032,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo | **`uuid`** | `fixed_le

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767616876 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to t

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767613662 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to t

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767610889 ## format/spec.md: ## @@ -174,6 +174,7 @@ Supported primitive types are defined in the table below. Primitive types added | Added by version | Primitive ty

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-13 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1759573632 ## format/spec.md: ## @@ -950,6 +977,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`uuid`**|`{ "type": "fixed",`  `"size":

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-13 Thread via GitHub
aihuaxu commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1759094008 ## format/spec.md: ## @@ -950,6 +977,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`uuid`**|`{ "type": "fixed",`  `"size"

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-08-21 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1725963520 ## format/spec.md: ## @@ -222,11 +228,41 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the table

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-08-21 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1725963520 ## format/spec.md: ## @@ -222,11 +228,41 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the table

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-08-21 Thread via GitHub
rdblue commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1725962969 ## format/spec.md: ## @@ -222,11 +228,41 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the table

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-08-21 Thread via GitHub
jacobmarble commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1725381015 ## format/spec.md: ## @@ -222,11 +228,41 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to the