Re: [PR] Spark: Move the Writer to a visitor [iceberg]

Fokko merged PR #9440: URL: https://github.com/apache/iceberg/pull/9440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Spark: Move the Writer to a visitor [iceberg]

Fokko commented on code in PR #9440: URL: https://github.com/apache/iceberg/pull/9440#discussion_r1479321515 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java: ## @@ -136,46 +135,126 @@ private ParquetValueWriter newOption(Type fieldType,

Re: [PR] Spark: Move the Writer to a visitor [iceberg]

amogh-jahagirdar commented on code in PR #9440: URL: https://github.com/apache/iceberg/pull/9440#discussion_r1478907380 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java: ## @@ -136,46 +135,126 @@ private ParquetValueWriter newOption(Type f