amogh-jahagirdar commented on code in PR #9440:
URL: https://github.com/apache/iceberg/pull/9440#discussion_r1478907380
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java:
##########
@@ -136,46 +135,126 @@ private ParquetValueWriter<?> newOption(Type fieldType,
ParquetValueWriter<?> wr
return ParquetValueWriters.option(fieldType, maxD, writer);
}
+ private static class LogicalTypeAnnotationParquetValueWriterVisitor
+ implements
LogicalTypeAnnotation.LogicalTypeAnnotationVisitor<ParquetValueWriter<?>> {
+
+ private final ColumnDescriptor desc;
+ private final PrimitiveType primitive;
+
+ LogicalTypeAnnotationParquetValueWriterVisitor(
+ ColumnDescriptor desc, PrimitiveType primitive) {
+ this.desc = desc;
+ this.primitive = primitive;
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.StringLogicalTypeAnnotation stringLogicalType)
{
+ return Optional.of(utf8Strings(desc));
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.EnumLogicalTypeAnnotation enumLogicalType) {
+ return Optional.of(utf8Strings(desc));
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.JsonLogicalTypeAnnotation jsonLogicalType) {
+ return Optional.of(utf8Strings(desc));
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.UUIDLogicalTypeAnnotation uuidLogicalType) {
+ return Optional.of(uuids(desc));
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.MapLogicalTypeAnnotation mapLogicalType) {
+ return
LogicalTypeAnnotation.LogicalTypeAnnotationVisitor.super.visit(mapLogicalType);
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.ListLogicalTypeAnnotation listLogicalType) {
+ return
LogicalTypeAnnotation.LogicalTypeAnnotationVisitor.super.visit(listLogicalType);
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>>
visit(DecimalLogicalTypeAnnotation decimal) {
+ switch (primitive.getPrimitiveTypeName()) {
+ case INT32:
+ return Optional.of(decimalAsInteger(desc, decimal.getPrecision(),
decimal.getScale()));
+ case INT64:
+ return Optional.of(decimalAsLong(desc, decimal.getPrecision(),
decimal.getScale()));
+ case BINARY:
+ case FIXED_LEN_BYTE_ARRAY:
+ return Optional.of(decimalAsFixed(desc, decimal.getPrecision(),
decimal.getScale()));
+ }
+ return Optional.empty();
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.DateLogicalTypeAnnotation dateLogicalType) {
+ return Optional.of(ParquetValueWriters.ints(desc));
+ }
+
+ @Override
+ public Optional<ParquetValueWriter<?>> visit(
+ LogicalTypeAnnotation.TimeLogicalTypeAnnotation timeLogicalType) {
+ if (timeLogicalType.getUnit() ==
LogicalTypeAnnotation.TimeUnit.MICROS) {
+ return Optional.of(ParquetValueWriters.longs(desc));
+ }
Review Comment:
Style nit, new line after the if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
