Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-12 Thread via GitHub
liurenjie1024 merged PR #502: URL: https://github.com/apache/iceberg-rust/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-06 Thread via GitHub
liurenjie1024 commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1706386977 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-06 Thread via GitHub
ZENOTME commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1705677244 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian Doubl

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-05 Thread via GitHub
liurenjie1024 commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1704830446 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-05 Thread via GitHub
ZENOTME commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1704224086 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian Doubl

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-04 Thread via GitHub
liurenjie1024 commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1703468335 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-04 Thread via GitHub
ZENOTME commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1703299049 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian Doubl

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-04 Thread via GitHub
ZENOTME commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1703299049 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian Doubl

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-04 Thread via GitHub
liurenjie1024 commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1703224232 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-08-04 Thread via GitHub
ZENOTME commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1703145788 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian Doubl

Re: [PR] Simplify PrimitiveLiteral [iceberg-rust]

2024-07-30 Thread via GitHub
liurenjie1024 commented on code in PR #502: URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1697087387 ## crates/iceberg/src/spec/values.rs: ## @@ -65,24 +65,14 @@ pub enum PrimitiveLiteral { Float(OrderedFloat), /// Stored as 8-byte little-endian