ZENOTME commented on code in PR #502:
URL: https://github.com/apache/iceberg-rust/pull/502#discussion_r1703145788
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -65,24 +65,14 @@ pub enum PrimitiveLiteral {
Float(OrderedFloat<f32>),
/// Stored as 8-byte little-endian
Double(OrderedFloat<f64>),
- /// Stores days from the 1970-01-01 in an 4-byte little-endian int
- Date(i32),
- /// Stores microseconds from midnight in an 8-byte little-endian long
- Time(i64),
- /// Timestamp without timezone
- Timestamp(i64),
- /// Timestamp with timezone
- Timestamptz(i64),
/// UTF-8 bytes (without length)
String(String),
- /// 16-byte big-endian value
- Uuid(Uuid),
- /// Binary value
- Fixed(Vec<u8>),
/// Binary value (without length)
Binary(Vec<u8>),
/// Stores unscaled value as big int. According to iceberg spec, the
precision must less than 38(`MAX_DECIMAL_PRECISION`) , so i128 is suit here.
Decimal(i128),
+ /// 16-byte big-endian value
+ Uuid(Uuid),
Review Comment:
I think this is unlike `Timestamp(i64)`. The benefit of remaining this is
that we can reuse some implementation of `Uuid`, e.g. when format.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
