jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1504733892
##
pyiceberg/partitioning.py:
##
@@ -215,3 +236,54 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1504603226
##
pyiceberg/partitioning.py:
##
@@ -215,3 +236,54 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
Fokko commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1504543693
##
pyiceberg/partitioning.py:
##
@@ -215,3 +236,54 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1499922547
##
pyiceberg/partitioning.py:
##
@@ -215,3 +236,54 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
syun64 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1499729828
##
pyiceberg/partitioning.py:
##
@@ -215,3 +236,54 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
jqin61 commented on PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#issuecomment-1959848004
> @jqin61 I wanted to do a second round, but I think you forgot to push? :)
Hi Fokko sorry for the delayed push of the fixes. It took a little time to
think through how to use t
Fokko commented on PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#issuecomment-1959113816
@jqin61 I wanted to do a second round, but I think you forgot to push? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1498025856
##
pyiceberg/partitioning.py:
##
@@ -215,3 +240,53 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1498024911
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1498023132
##
pyiceberg/partitioning.py:
##
@@ -215,3 +240,53 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1498019488
##
pyiceberg/partitioning.py:
##
@@ -193,6 +197,27 @@ def partition_type(self, schema: Schema) -> StructType:
nested_fields.append(NestedField(field.fi
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1498016056
##
pyiceberg/partitioning.py:
##
@@ -193,6 +197,27 @@ def partition_type(self, schema: Schema) -> StructType:
nested_fields.append(NestedField(field.fi
Fokko commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1497670291
##
pyiceberg/partitioning.py:
##
@@ -193,6 +197,27 @@ def partition_type(self, schema: Schema) -> StructType:
nested_fields.append(NestedField(field.fie
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496932026
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496930464
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496928516
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496928516
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496926708
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496925205
##
tests/integration/test_partitioning_key.py:
##
@@ -0,0 +1,722 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1496923619
##
pyiceberg/partitioning.py:
##
@@ -215,3 +240,53 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec,
old_schema: Schema, fre
)
)
Fokko commented on PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#issuecomment-1955191403
@jqin61 Nice! Thanks for working on this. It is getting late here, but this
is on my list for tomorrow 👍
--
This is an automated message from the Apache Git Service.
To respond to t
21 matches
Mail list logo
