jqin61 commented on code in PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#discussion_r1498019488
##########
pyiceberg/partitioning.py:
##########
@@ -193,6 +197,27 @@ def partition_type(self, schema: Schema) -> StructType:
nested_fields.append(NestedField(field.field_id, field.name,
result_type, required=False))
return StructType(*nested_fields)
+ def partition_to_path(self, data: Record, schema: Schema) -> str:
+ partition_type = self.partition_type(schema)
+ field_types = partition_type.fields
+
+ pos = 0
+ field_strs = []
+ value_strs = []
+ for field_name in data._position_to_field_name:
+ value = getattr(data, field_name)
Review Comment:
Yes, this class makes more sense to me now, thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
