github-actions[bot] commented on PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#issuecomment-2712135448
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #12079: Parquet: Fix Reader leak by
removing useless copy
URL: https://github.com/apache/iceberg/pull/12079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
github-actions[bot] commented on PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#issuecomment-2692989780
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
zizon commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1936633094
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +75,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
zizon commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1935015216
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +75,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
zizon commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1935008359
##
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##
@@ -219,6 +228,191 @@ public void testTwoLevelList() throws IOException {
assertThat(recor
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1932439872
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +75,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1932431503
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +82,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1932380455
##
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##
@@ -219,6 +228,191 @@ public void testTwoLevelList() throws IOException {
assertThat(reco
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1932375870
##
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##
@@ -219,6 +228,191 @@ public void testTwoLevelList() throws IOException {
assertThat(reco
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1932378730
##
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##
@@ -219,6 +228,191 @@ public void testTwoLevelList() throws IOException {
assertThat(reco
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1932375105
##
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##
@@ -219,6 +228,191 @@ public void testTwoLevelList() throws IOException {
assertThat(reco
zizon commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1930216929
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +82,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
zizon commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1929399227
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +82,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
nastra commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1929021070
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##
@@ -82,22 +82,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile
file, Configuration
zizon commented on PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#issuecomment-2613024665
cc @nastra @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zizon commented on PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#issuecomment-2612949803
I think I found the root cause.
```
2025-01-24T10:39:58.963+0800 WARNFinalizer
org.apache.iceberg.hadoop.HadoopStreams Unclosed input stream created by:
org.ap
zizon commented on PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#issuecomment-2612281531
Wait, I think the fix is incorrect.
The readConf do transfer ownership to FileIterator via init return, in
which should be cloused by caller.
On Fri, Jan 24, 2025 at 19:10 Edua
18 matches
Mail list logo
