zizon commented on PR #12079: URL: https://github.com/apache/iceberg/pull/12079#issuecomment-2612281531
Wait, I think the fix is incorrect. The readConf do transfer ownership to FileIterator via init return, in which should be cloused by caller. On Fri, Jan 24, 2025 at 19:10 Eduard Tudenhoefner ***@***.***> wrote: > ***@***.**** approved this pull request. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/12079#pullrequestreview-2572362479>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAEKPIB4YB5LZQQHME57ZDT2MINTFAVCNFSM6AAAAABVYZGKW2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZSGM3DENBXHE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
