Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra merged PR #9892: URL: https://github.com/apache/iceberg/pull/9892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on PR #9892: URL: https://github.com/apache/iceberg/pull/9892#issuecomment-1988354068 Thanks for the review @nastra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1519306801 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +686,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSnaps

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1519306478 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +686,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSnaps

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1519305652 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +686,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSnaps

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1519303478 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -149,29 +142,26 @@ public void testJsonConversionWithV1Manifests() { timestampMillis);

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on PR #9892: URL: https://github.com/apache/iceberg/pull/9892#issuecomment-1986579621 @nastra Thanks for the review. Reflected your comments. Could you review the new one? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517877405 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +689,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSn

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517865244 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -49,12 +50,23 @@ public void testJsonConversion() throws IOException { String json = Snapsh

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517865244 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -49,12 +50,23 @@ public void testJsonConversion() throws IOException { String json = Snapsh

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517839588 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -177,120 +177,115 @@ public void testCherryPickFromBranch() { long lastSnapshotId = tabl

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517838222 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1731,7 +1730,7 @@ public void testNoTrailingLocationSlash() { private String createManife

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517827090 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInp

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517821079 ## core/src/test/java/org/apache/iceberg/LocalTableOperations.java: ## @@ -63,7 +65,9 @@ public String metadataFileLocation(String fileName) { fileName,

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517624708 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -700,81 +689,82 @@ public void testAttemptToRollbackToCurrentSnapshot() { table.manageSnaps

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517622548 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -301,32 +296,31 @@ public void testCreateBranchFailsWhenRefAlreadyExists() { .hasMessag

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517622216 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -177,120 +177,115 @@ public void testCherryPickFromBranch() { long lastSnapshotId = table.c

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517621786 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -177,120 +177,115 @@ public void testCherryPickFromBranch() { long lastSnapshotId = table.c

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517620401 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1731,7 +1730,7 @@ public void testNoTrailingLocationSlash() { private String createManifestL

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517620107 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -87,7 +86,7 @@ public class TestTableMetadata { .desc(Expressions.bucket("z", 4), NullO

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517617834 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -49,12 +50,23 @@ public void testJsonConversion() throws IOException { String json = SnapshotP

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517616912 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -149,29 +182,34 @@ public void testJsonConversionWithV1Manifests() { timestampMillis);

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517615186 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInput;

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517614955 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInput;

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517614411 ## core/src/test/java/org/apache/iceberg/TestSnapshotJson.java: ## @@ -19,23 +19,24 @@ package org.apache.iceberg; import static org.apache.iceberg.Files.localInput;

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

nastra commented on code in PR #9892: URL: https://github.com/apache/iceberg/pull/9892#discussion_r1517614107 ## core/src/test/java/org/apache/iceberg/LocalTableOperations.java: ## @@ -63,7 +65,9 @@ public String metadataFileLocation(String fileName) { fileName,

Re: [PR] Migrate Snapshot files in Core to JUnit5 [iceberg]

tomtongue commented on PR #9892: URL: https://github.com/apache/iceberg/pull/9892#issuecomment-1985474689 @nastra Update the snapshot files. Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the