Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] closed pull request #11313: Kafka Connect: Add config to route to tables using topic name URL: https://github.com/apache/iceberg/pull/11313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2638321108 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2025-01-29 Thread via GitHub
github-actions[bot] commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2623223008 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-12-29 Thread via GitHub
xiasongh commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2564847217 Hey @bryanck @mun1r0b0t! Sorry! I've been a bit busy and this PR got lost. I can finish up this PR, but I'd like to get some thoughts on my previous comment so I can make

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-12-22 Thread via GitHub
github-actions[bot] commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2558674264 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-11-21 Thread via GitHub
mun1r0b0t commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2492647778 I opened up https://github.com/apache/iceberg/issues/11163 since I did not hear back on this. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-11-18 Thread via GitHub
mun1r0b0t commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2484098247 Hi folks, is this still being worked on? I have a similar need to route by topic, but the changes in this PR will not address my needs. I need to configure the topic for indivi

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-21 Thread via GitHub
xiasongh commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2427381877 > Thanks for the PR @xiasongh ! I'm interested in your thoughts on using a single property to define routing. If you agree, I can re-review once you make that change. Hi @bryanc

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-16 Thread via GitHub
bryanck commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2417500473 Thanks for the PR @xiasongh ! I'm interested in your thoughts on using a single property to define routing. If you agree, I can re-review once you make that change. -- This is an aut

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-16 Thread via GitHub
bryanck commented on code in PR #11313: URL: https://github.com/apache/iceberg/pull/11313#discussion_r1803549096 ## docs/docs/kafka-connect.md: ## @@ -87,8 +88,8 @@ for exactly-once semantics. This requires Kafka 2.5 or later. | iceberg.kafka.*| Prop

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-16 Thread via GitHub
bryanck commented on code in PR #11313: URL: https://github.com/apache/iceberg/pull/11313#discussion_r1803548713 ## docs/docs/kafka-connect.md: ## @@ -63,6 +63,7 @@ for exactly-once semantics. This requires Kafka 2.5 or later. | iceberg.tables | Comm

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-13 Thread via GitHub
xiasongh commented on code in PR #11313: URL: https://github.com/apache/iceberg/pull/11313#discussion_r1798594599 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -133,6 +145,20 @@ private String extractRouteValue(Object recordV

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-13 Thread via GitHub
xiasongh commented on code in PR #11313: URL: https://github.com/apache/iceberg/pull/11313#discussion_r1798594599 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -133,6 +145,20 @@ private String extractRouteValue(Object recordV

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2024-10-13 Thread via GitHub
xiasongh commented on code in PR #11313: URL: https://github.com/apache/iceberg/pull/11313#discussion_r1798594599 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -133,6 +145,20 @@ private String extractRouteValue(Object recordV