bryanck commented on code in PR #11313:
URL: https://github.com/apache/iceberg/pull/11313#discussion_r1803549096
##########
docs/docs/kafka-connect.md:
##########
@@ -87,8 +88,8 @@ for exactly-once semantics. This requires Kafka 2.5 or later.
| iceberg.kafka.* | Properties passed through to
control topic Kafka client initialization
|
If `iceberg.tables.dynamic-enabled` is `false` (the default) then you must
specify `iceberg.tables`. If
-`iceberg.tables.dynamic-enabled` is `true` then you must specify
`iceberg.tables.route-field` which will
-contain the name of the table.
+`iceberg.tables.dynamic-enabled` is `true` then you must specify either
`iceberg.tables.route-field` which will
+contain the name of the table or `iceberg.tables.route-pattern` which
specifies a format string for the table.
Review Comment:
If we go with a single property we can revert this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
