Fokko merged PR #289:
URL: https://github.com/apache/iceberg-python/pull/289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
kevinjqliu commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1986928262
@bitsondatadev
> I also am curious to know if this catalog still makes sense with inmem
sqlite?
We agreed to not move this implementation to production. See
https:/
bitsondatadev commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1986926827
> Thanks for working on this @kevinjqliu. The issues was created a long time
ago, before we had the SqlCatalog with sqlite support. Sqlite can also work [in
memory](https://www
kevinjqliu commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1979115277
Thanks for the suggestions, @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1512595725
##
tests/catalog/test_base.py:
##
@@ -72,6 +81,7 @@ def __init__(self, name: str, **properties: str) -> None:
super().__init__(name, **properties)
kevinjqliu commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1972473935
@Fokko As we discussed in #293, let's not create yet another catalog.
I moved the changes back to `test_base.py` where the In-Memory catalog was
originally. This PR improves the
