Fokko commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1512595725
##########
tests/catalog/test_base.py:
##########
@@ -72,6 +81,7 @@ def __init__(self, name: str, **properties: str) -> None:
super().__init__(name, **properties)
self.__tables = {}
self.__namespaces = {}
+ self._warehouse_location = properties.get(WAREHOUSE, None) or
DEFAULT_WAREHOUSE_LOCATION
Review Comment:
I think if it is set, we want to use it:
```suggestion
self._warehouse_location = properties.get(WAREHOUSE,
DEFAULT_WAREHOUSE_LOCATION)
```
##########
mkdocs/docs/configuration.md:
##########
@@ -260,6 +260,11 @@ catalog:
region_name: <REGION_NAME>
```
+## In-Memory Catalog
+
+The In-Memory catalog uses in-memory data-structures to store information.
+This is useful for test, demo, and playground. Do not use in production as the
data is not persisted.
+
Review Comment:
```suggestion
```
##########
mkdocs/docs/configuration.md:
##########
@@ -24,7 +24,7 @@ hide:
# Catalogs
-PyIceberg currently has native support for REST, SQL, Hive, Glue and DynamoDB.
+PyIceberg currently has native support for REST, SQL, Hive, Glue, DynamoDB,
and In-Memory catalogs.
Review Comment:
```suggestion
PyIceberg currently has native support for REST, SQL, Hive, Glue and
DynamoDB.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
