kevinjqliu merged PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
grihabor commented on PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#issuecomment-2662902704
@kevinjqliu Sure, merged wth upstream main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
grihabor commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1958109165
##
pyiceberg/table/update/__init__.py:
##
@@ -455,6 +456,57 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return bas
kevinjqliu commented on PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#issuecomment-2661608880
now that #1598 is merged, @grihabor could you rebase main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Fokko commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1939206950
##
pyiceberg/table/update/__init__.py:
##
@@ -455,6 +456,57 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return base_m
grihabor commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1938238860
##
pyiceberg/table/update/__init__.py:
##
@@ -455,6 +455,19 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return bas
kevinjqliu commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1938122584
##
tests/table/test_init.py:
##
@@ -793,6 +794,40 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table)
-> None:
)
+def test_update_remove_s
grihabor commented on PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#issuecomment-2624404466
Removed corresponding statistics files and entries from snapshot log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
grihabor commented on PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#issuecomment-2615744044
Fixed the linters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
grihabor commented on PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#issuecomment-2611088714
Hey @kevinjqliu, ready for another review round. I had to cherry pick the
changes from https://github.com/apache/iceberg-python/pull/822 to reuse the
code that removes refs
--
grihabor commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1927678717
##
pyiceberg/table/update/__init__.py:
##
@@ -455,6 +455,19 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return bas
grihabor commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1926141836
##
tests/table/test_init.py:
##
@@ -793,6 +794,34 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table)
-> None:
)
+def test_update_remove_sna
grihabor commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1926139112
##
pyiceberg/table/update/__init__.py:
##
@@ -455,6 +455,19 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return bas
kevinjqliu commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1925977119
##
tests/table/test_init.py:
##
@@ -793,6 +794,34 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table)
-> None:
)
+def test_update_remove_s
grihabor commented on PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#issuecomment-2607712878
Sure! Thanks for the fast review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
15 matches
Mail list logo