kevinjqliu commented on code in PR #1561:
URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1925977119
##########
tests/table/test_init.py:
##########
@@ -793,6 +794,34 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table)
-> None:
)
+def test_update_remove_snapshots(table_v2: Table) -> None:
+ update = RemoveSnapshotsUpdate(
+ snapshot_ids=[3051729675574597004],
+ )
+ new_metadata = update_table_metadata(table_v2.metadata, (update,))
+ assert len(new_metadata.snapshots) == 1
Review Comment:
if theres 1 snapshot, isnt that the current snapshot. if so, wouldnt it
error?
##########
pyiceberg/table/update/__init__.py:
##########
@@ -455,6 +455,19 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return base_metadata.model_copy(update=metadata_updates)
+@_apply_table_update.register(RemoveSnapshotsUpdate)
+def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context:
_TableMetadataUpdateContext) -> TableMetadata:
Review Comment:
this is the java reference
https://github.com/apache/iceberg/blob/be6e9daf8901cdee63197e77fcf95624bb694f39/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1396-L1426
##########
pyiceberg/table/update/__init__.py:
##########
@@ -455,6 +455,19 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return base_metadata.model_copy(update=metadata_updates)
+@_apply_table_update.register(RemoveSnapshotsUpdate)
+def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context:
_TableMetadataUpdateContext) -> TableMetadata:
+ for remove_snapshot_id in update.snapshot_ids:
+ if remove_snapshot_id == base_metadata.current_snapshot_id:
+ raise ValueError(f"Can't remove current snapshot id
{remove_snapshot_id}")
Review Comment:
should we block the current snapshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
