Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra merged PR #10082: URL: https://github.com/apache/iceberg/pull/10082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553435328 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveClientPool.java: ## @@ -116,6 +119,52 @@ public void testGetTablesFailsForNonReconnectableException()

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nk1506 commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553430668 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveClientPool.java: ## @@ -116,6 +119,52 @@ public void testGetTablesFailsForNonReconnectableException()

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553429104 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -970,6 +975,47 @@ public void testCatalogWithCustomMetricsReporter() throws IOException {

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553236192 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -970,6 +976,51 @@ public void testCatalogWithCustomMetricsReporter() throws IOException {

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553049382 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -970,6 +976,51 @@ public void testCatalogWithCustomMetricsReporter() throws IOException {

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nk1506 commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553083646 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -970,6 +976,51 @@ public void testCatalogWithCustomMetricsReporter() throws IOException {

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1553049382 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -970,6 +976,51 @@ public void testCatalogWithCustomMetricsReporter() throws IOException {

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1551437288 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java: ## @@ -138,7 +138,7 @@ public void doCommit(TableMetadata base, TableMetadata metadata) {

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1551398196 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java: ## @@ -59,29 +59,19 @@ public HiveClientPool(int poolSize, Configuration conf) { @Overr

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nk1506 commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1551350882 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java: ## @@ -59,29 +59,19 @@ public HiveClientPool(int poolSize, Configuration conf) { @Overr

Re: [PR] Hive, JDBC: Add null check before matching the error message [iceberg]

nastra commented on code in PR #10082: URL: https://github.com/apache/iceberg/pull/10082#discussion_r1551269821 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java: ## @@ -59,29 +59,19 @@ public HiveClientPool(int poolSize, Configuration conf) { @Overr