nk1506 commented on code in PR #10082:
URL: https://github.com/apache/iceberg/pull/10082#discussion_r1551350882
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java:
##########
@@ -59,29 +59,19 @@ public HiveClientPool(int poolSize, Configuration conf) {
@Override
protected IMetaStoreClient newClient() {
try {
- try {
- return GET_CLIENT.invoke(
- hiveConf, (HiveMetaHookLoader) tbl -> null,
HiveMetaStoreClient.class.getName());
- } catch (RuntimeException e) {
- // any MetaException would be wrapped into RuntimeException during
reflection, so let's
- // double-check type here
- if (e.getCause() instanceof MetaException) {
Review Comment:
the other try-catch block looks redundant . We were wrapping into
[MetaException](https://github.com/apache/iceberg/blob/main/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java#L69)
and throwing and again
[wrapping](https://github.com/apache/iceberg/blob/main/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java#L74)
into RuntimeMetaException .
Should I revert and add only null check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
