Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-22 Thread via GitHub
pvary commented on PR #10484: URL: https://github.com/apache/iceberg/pull/10484#issuecomment-2304799537 Merged to master. Thanks for the review @stevenzwu, @singhpk234 and @gyfora! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-22 Thread via GitHub
pvary merged PR #10484: URL: https://github.com/apache/iceberg/pull/10484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-22 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726595300 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-22 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726594832 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockFactoryBase.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726315077 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726304565 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726213077 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockFactoryBase.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726304565 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1726213077 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockFactoryBase.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724745652 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724721975 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockFactoryBase.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724718482 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724719157 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockFactoryBase.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724717076 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724712629 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724703605 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724698190 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724696254 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724524981 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724524205 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724522494 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724521388 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-21 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1724518086 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-19 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1722057725 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-12 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1713959444 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-12 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1713958997 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTagBasedLockFactory.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-12 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1713948194 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-07 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1707718356 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerLockFactory.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-07 Thread via GitHub
singhpk234 commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1707557043 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerLockFactory.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-06 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1705732746 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-06 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1705729180 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTagBasedLockFactory.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-06 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1705727844 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-06 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1705645226 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-06 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1705638405 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/MetricsReporterFactoryForTests.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apach

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1702043002 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701945987 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701520536 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701518242 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701501963 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701493223 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701495274 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701493223 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701481389 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701478003 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701471050 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701471050 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701468373 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701466221 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701465612 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701460602 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701447388 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTagBasedLockFactory.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701438248 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/MetricsReporterFactoryForTests.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apach

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701421084 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701419852 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701410482 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701399704 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-02 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701396639 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1701369847 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1700306350 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1700306350 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1700304518 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1700302146 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699877237 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699876545 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699712652 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699709058 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699704601 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699687077 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699663282 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699651831 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699587030 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-08-01 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1699585173 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698852703 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698483483 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698477231 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698473585 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698472738 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698470388 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698470388 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698469479 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698467590 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698465204 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698437502 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -83,7 +96,7 @@ class TriggerManager extends KeyedProcessFunc

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698436916 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698429306 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JVMBasedLockFactory.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698428895 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,295 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698418626 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,587 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-31 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1698414530 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-30 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1697286779 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-30 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1697278353 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-30 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1697276904 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-30 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1697274311 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-30 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1697274018 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-29 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1695810956 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-29 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1651100591 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-07-29 Thread via GitHub
pvary commented on PR #10484: URL: https://github.com/apache/iceberg/pull/10484#issuecomment-2255494823 Hi @stevenzwu, I would like to move forward with this PR. I see the following open questions: 1. Lock implementation - I still think it is important to provide a working imple

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-06-24 Thread via GitHub
stevenzwu commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1648221004 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JVMBasedLockFactory.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-06-18 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1643990192 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,587 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-06-18 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1643989763 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java: ## @@ -0,0 +1,587 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - TriggerManager [iceberg]

2024-06-18 Thread via GitHub
pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1643989141 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java: ## @@ -0,0 +1,295 @@ +/* + * Licensed to the Apache Software Found

  1   2   >