Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-27 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2108588368 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2100859083 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2100859083 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2100779566 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Fokko commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2100484719 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit_b

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2100082961 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2098978290 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-21 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2098978290 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-05-20 Thread via GitHub
Erigara commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2098978290 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit