Re: [PR] Docs: Enhance Flink pages [iceberg]

2024-03-11 Thread via GitHub
nastra merged PR #9919: URL: https://github.com/apache/iceberg/pull/9919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Docs: Enhance Flink pages [iceberg]

2024-03-11 Thread via GitHub
manuzhang commented on PR #9919: URL: https://github.com/apache/iceberg/pull/9919#issuecomment-1988090799 Here it is. https://github.com/apache/iceberg/assets/1191767/974005ab-aba9-4426-9404-f98bf81fa458";> -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Docs: Enhance Flink pages [iceberg]

2024-03-11 Thread via GitHub
nastra commented on PR #9919: URL: https://github.com/apache/iceberg/pull/9919#issuecomment-1988022320 @manuzhang is it then correctly intended with your changes? Can you post a screenshot please? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Docs: Enhance Flink pages [iceberg]

2024-03-11 Thread via GitHub
manuzhang commented on PR #9919: URL: https://github.com/apache/iceberg/pull/9919#issuecomment-1987972482 @nastra This is how the numbered list with code blocks look like without indentation https://github.com/apache/iceberg/assets/1191767/7193fd01-49e1-441e-a889-de932c48e820";>

Re: [PR] Docs: Enhance Flink pages [iceberg]

2024-03-11 Thread via GitHub
nastra commented on code in PR #9919: URL: https://github.com/apache/iceberg/pull/9919#discussion_r1519268222 ## docs/docs/flink-writes.md: ## @@ -59,20 +59,20 @@ Iceberg supports `UPSERT` based on the primary key when writing data into v2 tab 1. Enable the `UPSERT` mode as