nastra commented on code in PR #9919:
URL: https://github.com/apache/iceberg/pull/9919#discussion_r1519268222
##########
docs/docs/flink-writes.md:
##########
@@ -59,20 +59,20 @@ Iceberg supports `UPSERT` based on the primary key when
writing data into v2 tab
1. Enable the `UPSERT` mode as table-level property `write.upsert.enabled`.
Here is an example SQL statement to set the table property when creating a
table. It would be applied for all write paths to this table (batch or
streaming) unless overwritten by write options as described later.
-```sql
-CREATE TABLE `hive_catalog`.`default`.`sample` (
- `id` INT COMMENT 'unique id',
- `data` STRING NOT NULL,
- PRIMARY KEY(`id`) NOT ENFORCED
-) with ('format-version'='2', 'write.upsert.enabled'='true');
-```
+ ```sql
+ CREATE TABLE `hive_catalog`.`default`.`sample` (
+ `id` INT COMMENT 'unique id',
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+ ) with ('format-version'='2', 'write.upsert.enabled'='true');
+ ```
-2. Enabling `UPSERT` mode using `upsert-enabled` in the [write
options](#write-options) provides more flexibility than a table level config.
Note that you still need to use v2 table format and specify the primary key
when creating the table.
+2. Enabling `UPSERT` mode using `upsert-enabled` in the [write
options](#write-options) provides more flexibility than a table level config.
Note that you still need to use v2 table format and specify the [primary
key](../flink-ddl.md/#primary-key) or [identifier
fields](../../spec.md#identifier-field-ids) when creating the table.
-```sql
-INSERT INTO tableName /*+ OPTIONS('upsert-enabled'='true') */
-...
-```
+ ```sql
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
