Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on PR #8723: URL: https://github.com/apache/iceberg/pull/8723#issuecomment-1773504162 Thanks, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-20 Thread via GitHub
rdblue merged PR #8723: URL: https://github.com/apache/iceberg/pull/8723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347436052 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347411761 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347411761 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347395043 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347395043 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347395043 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347395043 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347395043 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
nastra commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347392925 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throws IOExcept

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
ajantha-bhat commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347371858 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throws IO

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347356619 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throw

Re: [PR] Core: Make view metadata properties optional in JSON parser [iceberg]

2023-10-05 Thread via GitHub
ajantha-bhat commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347242330 ## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throws IO