ajantha-bhat commented on code in PR #8723: URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347371858
########## core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java: ########## @@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen) throws IOException gen.writeStringField(VIEW_UUID, metadata.uuid()); gen.writeNumberField(FORMAT_VERSION, metadata.formatVersion()); gen.writeStringField(LOCATION, metadata.location()); - JsonUtil.writeStringMap(PROPERTIES, metadata.properties(), gen); + if (!metadata.properties().isEmpty()) { Review Comment: @amogh-jahagirdar: Table metadata , the read is still optional. But always writes. So, else case is a dead code. For view this PR is making both read and write optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org