Re: [PR] Core: List namespaces/tables when testing identifier with a dot [iceberg]

2025-01-20 Thread via GitHub
nastra merged PR #11991: URL: https://github.com/apache/iceberg/pull/11991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: List namespaces/tables when testing identifier with a dot [iceberg]

2025-01-19 Thread via GitHub
nastra commented on code in PR #11991: URL: https://github.com/apache/iceberg/pull/11991#discussion_r1921923905 ## open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java: ## @@ -90,4 +90,10 @@ protected boolean overridesRequestedLocation() {

Re: [PR] Core: List namespaces/tables when testing identifier with a dot [iceberg]

2025-01-19 Thread via GitHub
smaheshwar-pltr commented on code in PR #11991: URL: https://github.com/apache/iceberg/pull/11991#discussion_r1921682719 ## open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java: ## @@ -90,4 +90,10 @@ protected boolean overridesRequestedLocation()

Re: [PR] Core: List namespaces/tables when testing identifier with a dot [iceberg]

2025-01-17 Thread via GitHub
nastra commented on code in PR #11991: URL: https://github.com/apache/iceberg/pull/11991#discussion_r1920230431 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -499,6 +499,8 @@ public void testNamespaceWithDot() { catalog.createNamespace(withDot);

Re: [PR] Core: List namespaces/tables when testing identifier with a dot [iceberg]

2025-01-17 Thread via GitHub
nastra commented on code in PR #11991: URL: https://github.com/apache/iceberg/pull/11991#discussion_r1920229779 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -244,7 +244,7 @@ public void testLoadNamespaceMetadata() { assertThatThrownBy(() -> ca