smaheshwar-pltr commented on code in PR #11991:
URL: https://github.com/apache/iceberg/pull/11991#discussion_r1921682719
##########
open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java:
##########
@@ -90,4 +90,10 @@ protected boolean overridesRequestedLocation() {
RESTCompatibilityKitSuite.RCK_OVERRIDES_REQUESTED_LOCATION,
false);
}
+
+ @Override
+ protected boolean supportsNamesWithDot() {
+ // underlying JDBC catalog doesn't support namespaces with a dot
+ return false;
Review Comment:
(Semi-nit) The REST catalog that people test with the RCK *could* support
namespaces with a dot though, right? Should we maybe make this configurable via
```java
return PropertyUtil.propertyAsBoolean(
restCatalog.properties(),
RESTCompatibilityKitSuite.RCK_SUPPORTS_NAMES_WITH_DOT,
false);
```
like elsewhere in this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
