nastra merged PR #9765:
URL: https://github.com/apache/iceberg/pull/9765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497180424
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -150,6 +150,20 @@ public void initialize(String name, Map
properties) {
Thread.currentThr
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497178611
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +212,31 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExcept
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497176376
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +212,31 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExceptio
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497174469
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -150,6 +150,20 @@ public void initialize(String name, Map
properties) {
Thread.currentThrea
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497146435
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -150,6 +150,20 @@ public void initialize(String name, Map
properties) {
Thread.currentThr
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497144363
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -150,6 +150,20 @@ public void initialize(String name, Map
properties) {
Thread.currentThrea
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497115893
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +212,31 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExcept
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497114399
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +212,31 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExcept
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497113751
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +198,29 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExcept
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497088014
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +163,40 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catalog
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497069607
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +163,40 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catalog
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497068780
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +163,40 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catalog
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497067144
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +163,40 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catalog
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497038356
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +212,31 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExceptio
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497031984
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +212,31 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExceptio
ajantha-bhat commented on PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#issuecomment-1956009664
Keeping to V0 as default seems to be the right choice 👍 .
I think only thing missing is a testcase with `initializeCatalogTables =
false` as Eduard requested.
We can para
jbonofre commented on PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#issuecomment-1955906963
@rdblue @danielcweeks @nastra @ajantha-bhat I did a first update of the PR
according to Ryan's comments. I'm still working on a new test (the PR will be
updated soon with this test).
-
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496267090
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +198,29 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExcept
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496266194
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -140,6 +139,7 @@ public void initialize(String name, Map
properties) {
if (initializeCata
rdblue commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496263108
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -140,6 +139,7 @@ public void initialize(String name, Map
properties) {
if (initializeCatalo
rdblue commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496261892
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +198,29 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExceptio
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496233328
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -140,6 +139,7 @@ public void initialize(String name, Map
properties) {
if (initializeCata
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496232351
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +198,29 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExcept
nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496228499
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -199,21 +198,29 @@ private void initializeCatalogTables() throws
InterruptedException, SQLExceptio
jbonofre commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496228270
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -140,6 +139,7 @@ public void initialize(String name, Map
properties) {
if (initializeCata
rdblue commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496224382
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -140,6 +139,7 @@ public void initialize(String name, Map
properties) {
if (initializeCatalo
27 matches
Mail list logo
