nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497174469
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -150,6 +150,20 @@ public void initialize(String name, Map<String, String>
properties) {
Thread.currentThread().interrupt();
throw new UncheckedInterruptedException(e, "Interrupted in call to
initialize");
}
+
+ try {
+ updateSchemaIfRequired();
Review Comment:
> I think the try/catch should move into the `initializeCatalogTables`
method and `updateSchemaIfRequired` should have its own error handling.
Based on this it's what I mentioned previously: the error handling should
move *into* `initializeCatalogTables` + `updateSchemaIfRequired` should have
its own (and in that case I would also move it into the method itself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
