Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-12 Thread via GitHub
Fokko commented on PR #10498: URL: https://github.com/apache/iceberg/pull/10498#issuecomment-2225265862 Thanks @ebyhr for working on this 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-12 Thread via GitHub
Fokko merged PR #10498: URL: https://github.com/apache/iceberg/pull/10498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-11 Thread via GitHub
Fokko commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1675399327 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-11 Thread via GitHub
Fokko commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1675399047 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-10 Thread via GitHub
ebyhr commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1673173964 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-10 Thread via GitHub
Fokko commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1672042812 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -468,6 +468,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-05 Thread via GitHub
ebyhr commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1666476525 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -753,8 +753,9 @@ public void testListNamespace() { TableIdentifier tbl4 = TableIdentifier

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-05 Thread via GitHub
ebyhr commented on PR #10498: URL: https://github.com/apache/iceberg/pull/10498#issuecomment-2210408148 Addressed comments. Sorry for my late response. Iceberg IntelliJ project somehow broke after sending this PR. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-05 Thread via GitHub
ebyhr commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1666476525 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -753,8 +753,9 @@ public void testListNamespace() { TableIdentifier tbl4 = TableIdentifier

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-07-05 Thread via GitHub
nastra commented on PR #10498: URL: https://github.com/apache/iceberg/pull/10498#issuecomment-2210367412 @ebyhr thanks for working on this and it would be great to get this into 1.6.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-06-15 Thread via GitHub
jbonofre commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1641622324 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac

Re: [PR] Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces [iceberg]

2024-06-15 Thread via GitHub
findepi commented on code in PR #10498: URL: https://github.com/apache/iceberg/pull/10498#discussion_r1641426650 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -466,6 +466,16 @@ public List listNamespaces(Namespace namespace) throws NoSuchNamespac